build(deps): bump giithub.com/GaijinEntertainment/go-exhaustruct from v3.3.1 to 4.0.0 #5984

xobotyi · 2025-08-09T12:27:59Z

analyzer package is now distributed via vanity import as dev.gaijin.team/go/exhaustruct/v4.
version introduced new features which, in turn, required usage of structure as configuration causing major version bump.
updated documentation on config fields to be more obvious.

GaijinEntertainment/go-exhaustruct@v3.3.1...v4.0.0

For golangci-lint users nothing changes, except 4 new fields added, so no deprecations or migration on the users side is required.
Major bump of exhaustruct caused mostly because of package rename and the way config being passed to the linter.

note: go mod tidy touched more packages than i've expected

CLAassistant · 2025-08-09T12:28:04Z

All committers have signed the CLA.

ldez · 2025-08-09T12:30:56Z

This PR is based on golangci-lint v1 (the branch master).

The PR must target the branch main (golangci-lint v2).

The way to manage major (breaking) versions of linters has changed:

xobotyi · 2025-08-09T12:37:50Z

For golangci-lint users configuration itself still the same, just extra fields added and functionally without enabling new fields linter still acts the same.

Updated description regarding that.

ldez · 2025-08-09T12:44:05Z

ok, if there are no breaking changes, you don't need to use the new approach.

xobotyi · 2025-08-09T13:08:53Z

dang it! i see the issue now, the branch is wrong..

- analyzer package is now distributed via vanity import as `dev.gaijin.team/go/exhaustruct/v4`. - version introduced new features which, in turn, required usage of structure as configuration causing major version bump.

xobotyi · 2025-08-09T14:11:00Z

ready for review
note that this pr requires bumping go.mod go version to 1.24

ldez · 2025-08-09T14:31:28Z

You must downgrade your min go version inside your linter.

xobotyi · 2025-08-09T14:36:49Z

Welp, it is transitory.
Package we use is 1.24, and therefore linter is also.
IIRC golangci-lint targets oldstable, so it can be safely transitioned whenever 1.25 version support lands.

ldez · 2025-08-09T14:39:04Z

Your linter doesn't need go1.24: the module dev.gaijin.team/go/golib must downgrade the min Go version.

ldez · 2025-08-09T14:42:15Z

The min Go version is about the language (the syntax), a library should not enforce the latest stable version of Go unless it uses language-specific syntax related to this version.

In all cases, a library should not do that.

GaijinEntertainment/golib#1

ldez · 2025-08-09T14:48:02Z

.golangci.next.reference.yml

+        - '.*/http\.Cookie'
+      # Allows empty structures in return statements.
+      # Default: false
+      allow-empty-returns: false


Suggested change

allow-empty-returns: false

allow-empty-returns: true

ldez · 2025-08-09T14:48:10Z

.golangci.next.reference.yml

+      allow-empty-returns: false
+      # Allows empty structures in variable declarations.
+      # Default: false
+      allow-empty-declarations: false


Suggested change

allow-empty-declarations: false

allow-empty-declarations: true

ldez · 2025-08-09T14:49:02Z

.golangci.next.reference.yml

+      # List of regular expressions to match type names that should be
+      # processed. Anonymous structs can be matched by '<anonymous>' alias.
+      #
+      # Each regular expression must match the full type name, including package path.
+      # For example, to match type `net/http.Cookie` regular expression should be
+      # `.*/http\.Cookie`, but not `http\.Cookie`.
+      #


Suggested change

# List of regular expressions to match type names that should be

# processed. Anonymous structs can be matched by '<anonymous>' alias.

#

# Each regular expression must match the full type name, including package path.

# For example, to match type `net/http.Cookie` regular expression should be

# `.*/http\.Cookie`, but not `http\.Cookie`.

#

# List of regular expressions to match type names that should be processed.

# Anonymous structs can be matched by '<anonymous>' alias.

#

# Each regular expression must match the full type name, including package path.

# For example, to match type `net/http.Cookie` regular expression should be `.*/http\.Cookie`,

# but not `http\.Cookie`.

ldez · 2025-08-09T14:50:23Z

.golangci.next.reference.yml

+      # List of regular expressions to match type names that should be
+      # excluded from processing. Anonymous structs can be matched by '<anonymous>'
+      # alias.
+      # Has precedence over IncludeRx.
+      # Each regular expression must match the full type name, including package path.
+      # For example, to match type `net/http.Cookie` regular expression should be
+      # `.*/http\.Cookie`, but not `http\.Cookie`.


Suggested change

# List of regular expressions to match type names that should be

# excluded from processing. Anonymous structs can be matched by '<anonymous>'

# alias.

# Has precedence over IncludeRx.

# Each regular expression must match the full type name, including package path.

# For example, to match type `net/http.Cookie` regular expression should be

# `.*/http\.Cookie`, but not `http\.Cookie`.

# List of regular expressions to match type names that should be

# excluded from processing.

# Anonymous structs can be matched by '<anonymous>' alias.

# Has precedence over `include`.

# Each regular expression must match the full type name, including package path.

# For example, to match type `net/http.Cookie` regular expression should be `.*/http\.Cookie`,

# but not `http\.Cookie`.

ldez · 2025-08-09T14:51:50Z

.golangci.next.reference.yml

+      # List of regular expressions to match type names that should be
+      # allowed to be empty. Anonymous structs can be matched by '<anonymous>'
+      # alias.
+      # Each regular expression must match the full type name, including package path.
+      # For example, to match type `net/http.Cookie` regular expression should be
+      # `.*/http\.Cookie`, but not `http\.Cookie`.
+      # Default: []


Suggested change

# List of regular expressions to match type names that should be

# allowed to be empty. Anonymous structs can be matched by '<anonymous>'

# alias.

# Each regular expression must match the full type name, including package path.

# For example, to match type `net/http.Cookie` regular expression should be

# `.*/http\.Cookie`, but not `http\.Cookie`.

# Default: []

# List of regular expressions to match type names that should be allowed to be empty.

# Anonymous structs can be matched by '<anonymous>' alias.

# Each regular expression must match the full type name, including package path.

# For example, to match type `net/http.Cookie` regular expression should be `.*/http\.Cookie`,

# but not `http\.Cookie`.

# Default: []

ldez · 2025-08-09T14:52:11Z

go.mod

+go 1.24
+
+toolchain go1.24.6


Suggested change

go 1.24

toolchain go1.24.6

go 1.23.0

xobotyi · 2025-08-09T15:00:23Z

Linter itself will become dependant on 1.24 next minor release, because of usage of iterators on go types.

golib will also receive direct dependencies to features added in 1.24
there are features requiring these versions, just changes itself are not landed yet..

ldez · 2025-08-09T15:01:45Z

OK so I will not do more review or merge your PR until go1.25

xobotyi · 2025-08-09T15:03:30Z

No problems, I've expected that =)

ldez self-requested a review August 9, 2025 12:28

ldez added the linter: update version Update version of linter label Aug 9, 2025

ldez added the feedback required Requires additional feedback label Aug 9, 2025

xobotyi force-pushed the exhaustruct-v4 branch from f4e48d3 to 1870d9d Compare August 9, 2025 13:06

xobotyi force-pushed the exhaustruct-v4 branch 2 times, most recently from 74919d7 to 016b734 Compare August 9, 2025 13:38

feat: upgrade exhaustruct to v4

c378b92

- analyzer package is now distributed via vanity import as `dev.gaijin.team/go/exhaustruct/v4`. - version introduced new features which, in turn, required usage of structure as configuration causing major version bump.

xobotyi force-pushed the exhaustruct-v4 branch from 016b734 to c378b92 Compare August 9, 2025 13:51

ldez changed the title ~~feat: upgrade exhaustruct to v4~~ exhaustruct: upgrade to v4 Aug 9, 2025

ldez changed the title ~~exhaustruct: upgrade to v4~~ build(deps): bump giithub.com/GaijinEntertainment/go-exhaustruct/r from v3.3.1 to 4.0.0 Aug 9, 2025

ldez requested changes Aug 9, 2025

View reviewed changes

ldez marked this pull request as draft August 9, 2025 15:01

ldez added the blocked Need's direct action from maintainer label Aug 9, 2025

ldez changed the title ~~build(deps): bump giithub.com/GaijinEntertainment/go-exhaustruct/r from v3.3.1 to 4.0.0~~ build(deps): bump giithub.com/GaijinEntertainment/go-exhaustruct from v3.3.1 to 4.0.0 Aug 9, 2025

	allow-empty-declarations: false
	allow-empty-declarations: true

Uh oh!

build(deps): bump giithub.com/GaijinEntertainment/go-exhaustruct from v3.3.1 to 4.0.0 #5984

Are you sure you want to change the base?

build(deps): bump giithub.com/GaijinEntertainment/go-exhaustruct from v3.3.1 to 4.0.0 #5984

Uh oh!

Conversation

xobotyi commented Aug 9, 2025 • edited by ldez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldez commented Aug 9, 2025

Uh oh!

xobotyi commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldez commented Aug 9, 2025

Uh oh!

xobotyi commented Aug 9, 2025

Uh oh!

xobotyi commented Aug 9, 2025

Uh oh!

ldez commented Aug 9, 2025

Uh oh!

xobotyi commented Aug 9, 2025

Uh oh!

ldez commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldez commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldez Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

ldez Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

ldez Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

ldez Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

ldez Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

ldez Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

xobotyi commented Aug 9, 2025

Uh oh!

ldez commented Aug 9, 2025

Uh oh!

xobotyi commented Aug 9, 2025

Uh oh!

Uh oh!

xobotyi commented Aug 9, 2025 •

edited by ldez

Loading

CLAassistant commented Aug 9, 2025 •

edited

Loading

xobotyi commented Aug 9, 2025 •

edited

Loading

ldez commented Aug 9, 2025 •

edited

Loading

ldez commented Aug 9, 2025 •

edited

Loading